On Fri, Mar 24, 2017 at 11:15:25AM +0100, Harald Welte wrote:
> Hi Jonas,
>
> looks fine to me, but I haven't tested it. Did you manually test it
> using the extended libgtpnl + tools?
>
> Also, in code like this:
>
> + if (gtp->role == GTP_ROLE_SGSN) {
> + pctx = ipv4_pdp_find(gtp, iph->saddr);
> + } else {
>
> I think general Linux kernel coding style is to not have curly-brackets
> around single-line blocks. See "Do not unnecessarily use braces where a
> single statement will do." in line 169 of
> Documentation/process/coding-style.rst
>
> I won't mind your current style, and it is not a blocker issue to me,
> but still it would be nice for general consistency.
Harald is right, I overlook this comestic thing.
