On 10/8/20 11:15 AM, Johannes Berg wrote:
> On Thu, 2020-10-08 at 11:13 +0200, Johannes Berg wrote:
>
>>> This implies that all policy tables must be 'complete'.
>
> Also, yes they had to be complete already, perhaps *except* for NLA_FLAG
> like this below use ...
>
>>> So when later strset_p
On Thu, 2020-10-08 at 11:13 +0200, Johannes Berg wrote:
> > This implies that all policy tables must be 'complete'.
Also, yes they had to be complete already, perhaps *except* for NLA_FLAG
like this below use ...
> > So when later strset_parse_request() does :
> >
> > req_info->counts_only = tb
On Thu, 2020-10-08 at 11:12 +0200, Eric Dumazet wrote:
>
> On 10/6/20 12:07 AM, Jakub Kicinski wrote:
> > Since ethtool uses strict attribute validation there's no need
> > to initialize all attributes in policy tables. 0 is NLA_UNSPEC
> > which is going to be rejected. Remove the NLA_REJECTs.
> >
On 10/6/20 12:07 AM, Jakub Kicinski wrote:
> Since ethtool uses strict attribute validation there's no need
> to initialize all attributes in policy tables. 0 is NLA_UNSPEC
> which is going to be rejected. Remove the NLA_REJECTs.
>
> Similarly attributes above maxattrs are rejected, so there's
Since ethtool uses strict attribute validation there's no need
to initialize all attributes in policy tables. 0 is NLA_UNSPEC
which is going to be rejected. Remove the NLA_REJECTs.
Similarly attributes above maxattrs are rejected, so there's
no need to always size the policy tables to ETHTOOL_A_..
