On 10/8/20 11:15 AM, Johannes Berg wrote: > On Thu, 2020-10-08 at 11:13 +0200, Johannes Berg wrote: > >>> This implies that all policy tables must be 'complete'. > > Also, yes they had to be complete already, perhaps *except* for NLA_FLAG > like this below use ... > >>> So when later strset_parse_request() does : >>> >>> req_info->counts_only = tb[ETHTOOL_A_STRSET_COUNTS_ONLY]; >>> >> Here was the fix >> https://lore.kernel.org/netdev/20201007125348.a74389e18168.Ieab7a871e27b9698826e75dc9e825e4ddbc852b1@changeid/ > > Sorry, wrong link > > https://lore.kernel.org/netdev/20201007125348.a0b250308599.Ie9b429e276d064f28ce12db01fffa430e5c770e0@changeid/ > > johannes > SGTM, thanks !
- [PATCH net-next v2 0/7] ethtool: allow dumping policies to... Jakub Kicinski
- [PATCH net-next v2 4/7] ethtool: link up ethnl_header... Jakub Kicinski
- [PATCH net-next v2 7/7] ethtool: specify which header... Jakub Kicinski
- [PATCH net-next v2 3/7] ethtool: trim policy tables Jakub Kicinski
- Re: [PATCH net-next v2 3/7] ethtool: trim policy ... Eric Dumazet
- Re: [PATCH net-next v2 3/7] ethtool: trim pol... Johannes Berg
- Re: [PATCH net-next v2 3/7] ethtool: trim... Johannes Berg
- Re: [PATCH net-next v2 3/7] ethtool:... Eric Dumazet
- [PATCH net-next v2 6/7] netlink: add mask validation Jakub Kicinski
- [PATCH net-next v2 2/7] ethtool: wire up set policies... Jakub Kicinski
- [PATCH net-next v2 5/7] netlink: create helpers for c... Jakub Kicinski
- [PATCH net-next v2 1/7] ethtool: wire up get policies... Jakub Kicinski
- Re: [PATCH net-next v2 0/7] ethtool: allow dumping po... Johannes Berg
- Re: [PATCH net-next v2 0/7] ethtool: allow dumpin... David Miller
- Re: [PATCH net-next v2 0/7] ethtool: allow du... Leon Romanovsky
- Re: [PATCH net-next v2 0/7] ethtool: allo... Johannes Berg
- Re: [PATCH net-next v2 0/7] ethtool:... Leon Romanovsky
- Re: [PATCH net-next v2 0/7] etht... Johannes Berg