Re: [PATCH net-next v2 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

2021-03-26 Thread Andrew Lunn
On Thu, Mar 25, 2021 at 07:07:24PM -0700, Jakub Kicinski wrote: > struct ethtool_fecparam::reserved is never looked at by the core. > Make sure it's actually 0. Unfortunately we can't return an error > because old ethtool doesn't zero-initialize the structure for SET. > On GET we can be more verbos

[PATCH net-next v2 3/6] ethtool: fec: sanitize ethtool_fecparam->reserved

2021-03-25 Thread Jakub Kicinski
struct ethtool_fecparam::reserved is never looked at by the core. Make sure it's actually 0. Unfortunately we can't return an error because old ethtool doesn't zero-initialize the structure for SET. On GET we can be more verbose, there are no in tree (ab)users. Fix up the kdoc on the structure. Re