On Thu, Mar 25, 2021 at 07:07:24PM -0700, Jakub Kicinski wrote: > struct ethtool_fecparam::reserved is never looked at by the core. > Make sure it's actually 0. Unfortunately we can't return an error > because old ethtool doesn't zero-initialize the structure for SET. > On GET we can be more verbose, there are no in tree (ab)users. > > Fix up the kdoc on the structure. Remove the mention of FEC > bypass. Seems like a niche thing to configure in the first > place. > > v2: - also mention the zero-init-on-SET kerfuffle in kdoc > > Signed-off-by: Jakub Kicinski <[email protected]>
Reviewed-by: Andrew Lunn <[email protected]> Andrew
