Re: [PATCH net-next v2] r8169: improve interrupt handling

2018-02-27 Thread David Miller
From: Heiner Kallweit Date: Mon, 26 Feb 2018 20:50:32 +0100 > Am 26.02.2018 um 19:56 schrieb David Miller: >> From: Heiner Kallweit >> Date: Sat, 24 Feb 2018 16:53:23 +0100 >> >>> @@ -736,8 +736,7 @@ struct ring_info { >>> }; >>> >>> enum features { >>> - RTL_FEATURE_MSI = (1 << 0

Re: [PATCH net-next v2] r8169: improve interrupt handling

2018-02-26 Thread Heiner Kallweit
Am 26.02.2018 um 19:56 schrieb David Miller: > From: Heiner Kallweit > Date: Sat, 24 Feb 2018 16:53:23 +0100 > >> @@ -736,8 +736,7 @@ struct ring_info { >> }; >> >> enum features { >> -RTL_FEATURE_MSI = (1 << 0), >> -RTL_FEATURE_GMII= (1 << 1), >> +RTL_FEATURE_GMII

Re: [PATCH net-next v2] r8169: improve interrupt handling

2018-02-26 Thread David Miller
From: Heiner Kallweit Date: Sat, 24 Feb 2018 16:53:23 +0100 > @@ -736,8 +736,7 @@ struct ring_info { > }; > > enum features { > - RTL_FEATURE_MSI = (1 << 0), > - RTL_FEATURE_GMII= (1 << 1), > + RTL_FEATURE_GMII= (1 << 0), > }; > > struct rtl8169_counter

[PATCH net-next v2] r8169: improve interrupt handling

2018-02-24 Thread Heiner Kallweit
This patch improves few aspects of interrupt handling: - update to current interrupt allocation API (use pci_alloc_irq_vectors() instead of deprecated pci_enable_msi()) - this implicitly will allocate a MSI-X interrupt if available - get rid of flag RTL_FEATURE_MSI - remove some dead code, intent