From: Heiner Kallweit <hkallwe...@gmail.com>
Date: Sat, 24 Feb 2018 16:53:23 +0100

> @@ -736,8 +736,7 @@ struct ring_info {
>  };
>  
>  enum features {
> -     RTL_FEATURE_MSI         = (1 << 0),
> -     RTL_FEATURE_GMII        = (1 << 1),
> +     RTL_FEATURE_GMII        = (1 << 0),
>  };
>  
>  struct rtl8169_counters {
 ...
> +     if (tp->mac_version <= RTL_GIGA_MAC_VER_06) {

Please, if you are going to keep the logic the same for the older
chips, just keep the RTL_FEATURE_MSI flag around instead of adding
new (and potentially regression causing) tests for this condition.

Thank you.

Reply via email to