Re: [PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-09 Thread Thomas Graf
On 12/08/15 at 08:08pm, David Ahern wrote: > On 12/8/15 7:44 PM, David Miller wrote: > >Unfortunately it's too late for this, you should have considered this > >issue fully when VRF first went into an upstream release. > > > >If I add your change, the user experience is _worse_. > > > >Users on old

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-08 Thread roopa
On 12/8/15, 7:41 PM, David Miller wrote: > From: David Ahern > Date: Tue, 8 Dec 2015 20:21:51 -0700 > >> On 12/8/15 8:08 PM, David Ahern wrote: >>> root@kenny-jessie2:~# ip ru add oif vrf-red lookup vrf-red >>> >>> root@kenny-jessie2:~# ip ru ls >>> 0:from all lookup local >>> 32759:from a

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-08 Thread David Miller
From: David Ahern Date: Tue, 8 Dec 2015 20:21:51 -0700 > On 12/8/15 8:08 PM, David Ahern wrote: >> root@kenny-jessie2:~# ip ru add oif vrf-red lookup vrf-red >> >> root@kenny-jessie2:~# ip ru ls >> 0:from all lookup local >> 32759:from all oif vrf-red lookup vrf-red >> 32760:from all

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-08 Thread David Miller
From: David Ahern Date: Tue, 8 Dec 2015 20:08:31 -0700 > On 12/8/15 7:44 PM, David Miller wrote: >> Unfortunately it's too late for this, you should have considered this >> issue fully when VRF first went into an upstream release. >> >> If I add your change, the user experience is _worse_. >> >>

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-08 Thread David Ahern
On 12/8/15 8:08 PM, David Ahern wrote: root@kenny-jessie2:~# ip ru add oif vrf-red lookup vrf-red root@kenny-jessie2:~# ip ru ls 0:from all lookup local 32759:from all oif vrf-red lookup vrf-red 32760:from all iif vrf-green lookup vrf-green 32761:from all oif vrf-green lookup vrf

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-08 Thread David Ahern
On 12/8/15 7:44 PM, David Miller wrote: Unfortunately it's too late for this, you should have considered this issue fully when VRF first went into an upstream release. If I add your change, the user experience is _worse_. Users on older kernels have to use the full sequence, then if they upgrad

Re: [PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-08 Thread David Miller
From: David Ahern Date: Tue, 8 Dec 2015 12:48:05 -0800 > VRFs require ip rules for route lookups to work properly. Currently > creating a VRF means instantiating a device and then adding the 4 ip > and ip6 rules: > > ip link add vrf-${VRF} type vrf table ${TBID} > ip ru add oif vrf-${VR

[PATCH net-next v2] net: Add fib rules at vrf device create

2015-12-08 Thread David Ahern
VRFs require ip rules for route lookups to work properly. Currently creating a VRF means instantiating a device and then adding the 4 ip and ip6 rules: ip link add vrf-${VRF} type vrf table ${TBID} ip ru add oif vrf-${VRF} table ${TBID} ip ru add iif vrf-${VRF} table ${TBID} ip -6