On 12/08/15 at 08:08pm, David Ahern wrote: > On 12/8/15 7:44 PM, David Miller wrote: > >Unfortunately it's too late for this, you should have considered this > >issue fully when VRF first went into an upstream release. > > > >If I add your change, the user experience is _worse_. > > > >Users on older kernels have to use the full sequence, then if they > >upgrade their kernels to one with this patch then the 'ru add' et > >al. commands will fail. > > > > Perhaps this is another fug (feature bug), they do not fail: > > root@kenny-jessie2:~# ip ru ls > 0: from all lookup local > 32760: from all iif vrf-green lookup vrf-green > 32761: from all oif vrf-green lookup vrf-green > 32762: from all iif vrf-blue lookup vrf-blue > 32763: from all oif vrf-blue lookup vrf-blue > 32764: from all iif vrf-red lookup vrf-red > 32765: from all oif vrf-red lookup vrf-red > 32766: from all lookup main > 32767: from all lookup default > > root@kenny-jessie2:~# ip ru add oif vrf-red lookup vrf-red
This is not a bug. FIB rules can include forward jumps so it's perfectly valid to have the same rule in the entire chain multiple times. Just like it is for iptables and multiple chains. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
