Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Michal Kubecek
On Mon, Dec 07, 2020 at 02:11:48PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> + * expressed in terms of X in '(1 + X)*64 + 4' > > > > Is this way of expressing the min frag size from the standard? > >

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Jakub Kicinski
On Tue, 8 Dec 2020 00:27:31 + Vladimir Oltean wrote: > On Mon, Dec 07, 2020 at 04:24:02PM -0800, Vinicius Costa Gomes wrote: > > Jakub Kicinski writes: > > > > > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > > >> Jakub Kicinski writes: > > >> >> + * @min_frag_size_mul

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vladimir Oltean
On Mon, Dec 07, 2020 at 04:24:02PM -0800, Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > > > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > >> Jakub Kicinski writes: > >> >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> >> + * expressed in t

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: > On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: >> Jakub Kicinski writes: >> >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, >> >> + * expressed in terms of X in '(1 + X)*64 + 4' >> > >> > Is this way of expressing the min frag

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Jakub Kicinski
On Mon, 07 Dec 2020 14:11:48 -0800 Vinicius Costa Gomes wrote: > Jakub Kicinski writes: > >> + * @min_frag_size_mult: Minimum size for all non-final fragment size, > >> + * expressed in terms of X in '(1 + X)*64 + 4' > > > > Is this way of expressing the min frag size from the standard? > > >

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-07 Thread Vinicius Costa Gomes
Jakub Kicinski writes: >> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h >> index e3da25b51ae4..16d6ee29a6ac 100644 >> --- a/include/linux/ethtool.h >> +++ b/include/linux/ethtool.h >> @@ -263,6 +263,19 @@ struct ethtool_pause_stats { >> u64 rx_pause_frames; >> }; >> >> +/

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-05 Thread Jakub Kicinski
On Tue, 1 Dec 2020 20:53:17 -0800 Vinicius Costa Gomes wrote: > Frame preemption (described in IEEE 802.3br-2016) defines the concept > of preemptible and express queues. It allows traffic from express > queues to "interrupt" traffic from preemptible queues, which are > "resumed" after the express

Re: [PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-02 Thread Jakub Kicinski
On Tue, 1 Dec 2020 20:53:17 -0800 Vinicius Costa Gomes wrote: > Frame preemption (described in IEEE 802.3br-2016) defines the concept > of preemptible and express queues. It allows traffic from express > queues to "interrupt" traffic from preemptible queues, which are > "resumed" after the express

[PATCH net-next v1 1/9] ethtool: Add support for configuring frame preemption

2020-12-01 Thread Vinicius Costa Gomes
Frame preemption (described in IEEE 802.3br-2016) defines the concept of preemptible and express queues. It allows traffic from express queues to "interrupt" traffic from preemptible queues, which are "resumed" after the express traffic has finished transmitting. Frame preemption can only be used