RE: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-04 Thread Fugang Duan
adead.org; l...@boundarydevices.com; shawn...@kernel.org; > johan...@sipsolutions.net; stillcompil...@gmail.com; > sergei.shtyl...@cogentembedded.com; a...@arndb.de; Troy Kisky > > Subject: [PATCH net-next V2 04/16] net: fec: reduce interrupts > > By clearing the NAPI interrupts

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Zhi Li
On Wed, Mar 2, 2016 at 4:32 PM, Troy Kisky wrote: > FEC_ENET_TS_TIMER I think so. TS_TIMER should never be triggered. best regards Frank Li

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Troy Kisky
On 3/2/2016 9:47 AM, Zhi Li wrote: > On Wed, Mar 2, 2016 at 10:12 AM, Troy Kisky > wrote: >> On 3/2/2016 8:13 AM, Fugang Duan wrote: >>> From: Troy Kisky Sent: Thursday, February >>> 25, 2016 8:37 AM -if (fep->ptp_clock) +if ((int_events & FEC_ENET_TS_TIMER) && fep->ptp_cl

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Zhi Li
ogentembedded.com; a...@arndb.de; Troy Kisky >>> >>> Subject: [PATCH net-next V2 04/16] net: fec: reduce interrupts >>> >>> By clearing the NAPI interrupts in the NAPI routine and not in the interrupt >>> handler, we can reduce the number of interrupts.

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Zhi Li
On Wed, Mar 2, 2016 at 10:12 AM, Troy Kisky wrote: > it is going to be delayed for a very long time. > Should it be moved to the napi routine? No! irq can generate. Compared irq enable is not controlled by EIMR, but TCSR. Original code is correct. best regards Frank Li

Re: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Troy Kisky
; li...@arm.linux.org.uk; linux-arm- >> ker...@lists.infradead.org; l...@boundarydevices.com; shawn...@kernel.org; >> johan...@sipsolutions.net; stillcompil...@gmail.com; >> sergei.shtyl...@cogentembedded.com; a...@arndb.de; Troy Kisky >> >> Subject: [PATCH net-next V

RE: [PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-03-02 Thread Fugang Duan
adead.org; l...@boundarydevices.com; shawn...@kernel.org; > johan...@sipsolutions.net; stillcompil...@gmail.com; > sergei.shtyl...@cogentembedded.com; a...@arndb.de; Troy Kisky > > Subject: [PATCH net-next V2 04/16] net: fec: reduce interrupts > > By clearing the NAPI interrupts

[PATCH net-next V2 04/16] net: fec: reduce interrupts

2016-02-24 Thread Troy Kisky
By clearing the NAPI interrupts in the NAPI routine and not in the interrupt handler, we can reduce the number of interrupts. We also don't need any status variables as the registers are still valid. Also, notice that if budget pkts are received, the next call to fec_enet_rx_napi will now continue