Re: [PATCH net-next 5/7] net: dsa: felix: delete .phylink_mac_an_restart code

2020-06-26 Thread Russell King - ARM Linux admin
On Fri, Jun 26, 2020 at 02:19:42PM +0300, Vladimir Oltean wrote: > On Fri, 26 Jun 2020 at 14:08, Russell King - ARM Linux admin > wrote: > > > > [snip] > > > > > So, I ask again, what practical use and benefit does restarting the > > configuration exchange on a SGMII or USXGMII link have? Give

Re: [PATCH net-next 5/7] net: dsa: felix: delete .phylink_mac_an_restart code

2020-06-26 Thread Vladimir Oltean
On Fri, 26 Jun 2020 at 14:08, Russell King - ARM Linux admin wrote: > [snip] > > So, I ask again, what practical use and benefit does restarting the > configuration exchange on a SGMII or USXGMII link have? Give me a real > life use case where there's a problem with a link that this can solve.

Re: [PATCH net-next 5/7] net: dsa: felix: delete .phylink_mac_an_restart code

2020-06-26 Thread Russell King - ARM Linux admin
On Fri, Jun 26, 2020 at 11:53:24AM +0300, Vladimir Oltean wrote: > Hi Russell, > > On Thu, 25 Jun 2020 at 19:53, Russell King - ARM Linux admin > wrote: > > > > On Thu, Jun 25, 2020 at 06:23:29PM +0300, Vladimir Oltean wrote: > > > From: Vladimir Oltean > > > > > > In hardware, the AN_RESTART fi

Re: [PATCH net-next 5/7] net: dsa: felix: delete .phylink_mac_an_restart code

2020-06-26 Thread Vladimir Oltean
Hi Russell, On Thu, 25 Jun 2020 at 19:53, Russell King - ARM Linux admin wrote: > > On Thu, Jun 25, 2020 at 06:23:29PM +0300, Vladimir Oltean wrote: > > From: Vladimir Oltean > > > > In hardware, the AN_RESTART field for these SerDes protocols (SGMII, > > USXGMII) clears the resolved configurati

Re: [PATCH net-next 5/7] net: dsa: felix: delete .phylink_mac_an_restart code

2020-06-25 Thread Russell King - ARM Linux admin
On Thu, Jun 25, 2020 at 06:23:29PM +0300, Vladimir Oltean wrote: > From: Vladimir Oltean > > In hardware, the AN_RESTART field for these SerDes protocols (SGMII, > USXGMII) clears the resolved configuration from the PCS's > auto-negotiation state machine. > > But PHYLINK has a different interpre

[PATCH net-next 5/7] net: dsa: felix: delete .phylink_mac_an_restart code

2020-06-25 Thread Vladimir Oltean
From: Vladimir Oltean In hardware, the AN_RESTART field for these SerDes protocols (SGMII, USXGMII) clears the resolved configuration from the PCS's auto-negotiation state machine. But PHYLINK has a different interpretation of "AN restart". It assumes that this Linux system is capable of re-trig