Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

2020-10-11 Thread Michael Chan
On Sun, Oct 11, 2020 at 2:53 PM Jakub Kicinski wrote: > > I'm talking about bnxt_dbg_dump_states specifically. > > I'm looking at net-next: > > bnxt_rx_pkt >bnxt_sched_reset > set_bit(BNXT_RESET_TASK_SP_EVENT, &bp->sp_event); > > > bnxt_sp_task >bnxt_reset > bnxt_reset_task >

Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 14:13:04 -0700 Michael Chan wrote: > On Sun, Oct 11, 2020 at 12:34 PM Jakub Kicinski wrote: > > > > On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote: > > > Currently, bp->msg_enable has default value of 0. It is more useful > > > to have the commonly used NETIF_MSG_DRV

Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

2020-10-11 Thread Michael Chan
On Sun, Oct 11, 2020 at 12:34 PM Jakub Kicinski wrote: > > On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote: > > Currently, bp->msg_enable has default value of 0. It is more useful > > to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by > > default. > > > > Reviewed-by: Edwin

Re: [PATCH net-next 3/9] bnxt_en: Set driver default message level.

2020-10-11 Thread Jakub Kicinski
On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote: > Currently, bp->msg_enable has default value of 0. It is more useful > to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by > default. > > Reviewed-by: Edwin Peer > Reviewed-by: Vasundhara Volam > Signed-off-by: Michael Chan

[PATCH net-next 3/9] bnxt_en: Set driver default message level.

2020-10-11 Thread Michael Chan
Currently, bp->msg_enable has default value of 0. It is more useful to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by default. Reviewed-by: Edwin Peer Reviewed-by: Vasundhara Volam Signed-off-by: Michael Chan --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 2 ++ 1 file chang