On Sun, 11 Oct 2020 14:13:04 -0700 Michael Chan wrote:
> On Sun, Oct 11, 2020 at 12:34 PM Jakub Kicinski <[email protected]> wrote:
> >
> > On Sun, 11 Oct 2020 06:22:55 -0400 Michael Chan wrote:
> > > Currently, bp->msg_enable has default value of 0. It is more useful
> > > to have the commonly used NETIF_MSG_DRV and NETIF_MSG_HW enabled by
> > > default.
> > >
> > > Reviewed-by: Edwin Peer <[email protected]>
> > > Reviewed-by: Vasundhara Volam <[email protected]>
> > > Signed-off-by: Michael Chan <[email protected]>
> >
> > This will add whole bunch of output for "RX buffer error 4000[45]", no?
> > That one needs to switch to a silent reset first, I'd think.
>
> The last round of net-next patches have made changes to reduce this
> noise already. If the firmware supports the new RING_MONITOR scheme,
> There will be no more messages. The reset will be counted in a new
> ethtool -S counter only.
>
> If the firmware is older and does not support the new scheme, we've
> changed the logging to warn_once() in addition to the ethtool -S
> counter. There is no point in warning more than once.
I'm talking about bnxt_dbg_dump_states specifically.
I'm looking at net-next:
bnxt_rx_pkt
bnxt_sched_reset
set_bit(BNXT_RESET_TASK_SP_EVENT, &bp->sp_event);
bnxt_sp_task
bnxt_reset
bnxt_reset_task
bnxt_dbg_dump_states
