Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-18 Thread Paolo Abeni
On Wed, 2017-10-18 at 12:05 -0700, Martin KaFai Lau wrote: > Another thing (not limited to this case), > > Considering we have a limited size in the exception table now and > the oldest one will get removed when the table is full, > do we still need to purge this periodically in gc? At least in s

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-18 Thread Martin KaFai Lau
On Wed, Oct 18, 2017 at 05:56:39PM +, Wei Wang wrote: > On Wed, Oct 18, 2017 at 6:03 AM, Paolo Abeni wrote: > > On Tue, 2017-10-17 at 13:48 -0700, Wei Wang wrote: > >> On Tue, Oct 17, 2017 at 1:02 PM, Paolo Abeni wrote: > >> > Meanwhile others sockets may grab more references to (and use) the

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-18 Thread Wei Wang
On Wed, Oct 18, 2017 at 6:03 AM, Paolo Abeni wrote: > On Tue, 2017-10-17 at 13:48 -0700, Wei Wang wrote: >> On Tue, Oct 17, 2017 at 1:02 PM, Paolo Abeni wrote: >> > Meanwhile others sockets may grab more references to (and use) the same >> > aged-out dst. >> > >> >> I don't think other sockets co

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-18 Thread Paolo Abeni
On Tue, 2017-10-17 at 13:48 -0700, Wei Wang wrote: > On Tue, Oct 17, 2017 at 1:02 PM, Paolo Abeni wrote: > > Meanwhile others sockets may grab more references to (and use) the same > > aged-out dst. > > > > I don't think other sockets could grab more reference to this dst > because this dst shou

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Martin KaFai Lau
On Tue, Oct 17, 2017 at 06:58:23PM +, Wei Wang wrote: > On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set > > dst.obsolete when a cached route has expired"). > >

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Wei Wang
On Tue, Oct 17, 2017 at 1:02 PM, Paolo Abeni wrote: > On Tue, 2017-10-17 at 11:58 -0700, Wei Wang wrote: >> On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: >> > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store >> > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set >> >

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Paolo Abeni
On Tue, 2017-10-17 at 11:58 -0700, Wei Wang wrote: > On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set > > dst.obsolete when a cached route has expired"). > > > > Th

Re: [PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Wei Wang
On Tue, Oct 17, 2017 at 10:40 AM, Paolo Abeni wrote: > The commit 2b760fcf5cfb ("ipv6: hook up exception table to store > dst cache") partially reverted 1e2ea8ad37be ("ipv6: set > dst.obsolete when a cached route has expired"). > > This change brings back the dst obsoleting and push it a step > fa

[PATCH net-next 3/3] ipv6: obsolete cached dst when removing them from fib tree

2017-10-17 Thread Paolo Abeni
The commit 2b760fcf5cfb ("ipv6: hook up exception table to store dst cache") partially reverted 1e2ea8ad37be ("ipv6: set dst.obsolete when a cached route has expired"). This change brings back the dst obsoleting and push it a step farther: cached dst are always obsoleted when removed from the fib