Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread David Miller
From: Tom Herbert Date: Tue, 8 Dec 2015 16:11:56 -0800 > I thought about a TLV implementation but there is no base support in > the kernel for it. It would be great if you could implement the TLV > loop. Honestly, though, I'm still very leery of the processing > overhead associated with TLVs in t

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread Jesse Gross
On Tue, Dec 8, 2015 at 4:11 PM, Tom Herbert wrote: > On Tue, Dec 8, 2015 at 3:58 PM, Jesse Gross wrote: >> On Tue, Dec 8, 2015 at 11:59 AM, Tom Herbert wrote: >>> On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville Jesse is going to have to comment on your (ab)use of the reserved fields.

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread Tom Herbert
On Tue, Dec 8, 2015 at 3:58 PM, Jesse Gross wrote: > On Tue, Dec 8, 2015 at 11:59 AM, Tom Herbert wrote: >> On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville >> wrote: >>> On Tue, Dec 08, 2015 at 10:27:18AM -0800, Tom Herbert wrote: Add support for remote checksum offload in both the normal

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread Jesse Gross
On Tue, Dec 8, 2015 at 11:59 AM, Tom Herbert wrote: > On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville > wrote: >> On Tue, Dec 08, 2015 at 10:27:18AM -0800, Tom Herbert wrote: >>> Add support for remote checksum offload in both the normal and GRO >>> paths. netlink command are used to enable sen

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread kbuild test robot
Hi Tom, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Tom-Herbert/rco-Clean-up-casting-errors/20151209-022902 coccinelle warnings: (new ones prefixed by >>) >> drivers/net/geneve.c:371:6-12: ERROR: application of sizeof to pointer Please review

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread Tom Herbert
On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville wrote: > On Tue, Dec 08, 2015 at 10:27:18AM -0800, Tom Herbert wrote: >> Add support for remote checksum offload in both the normal and GRO >> paths. netlink command are used to enable sending of the Remote >> Checksum Data, and allow processing of

Re: [PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread John W. Linville
On Tue, Dec 08, 2015 at 10:27:18AM -0800, Tom Herbert wrote: > Add support for remote checksum offload in both the normal and GRO > paths. netlink command are used to enable sending of the Remote > Checksum Data, and allow processing of it on receive. The Remote afsO&^(*&5^a+++NO CARRIER Did you

[PATCH net-next 3/3] geneve: Remote Checksum Offload support

2015-12-08 Thread Tom Herbert
Add support for remote checksum offload in both the normal and GRO paths. netlink command are used to enable sending of the Remote Checksum Data, and allow processing of it on receive. The Remote Signed-off-by: Tom Herbert --- drivers/net/geneve.c | 162 ++