On Tue, Dec 8, 2015 at 11:31 AM, John W. Linville <linvi...@tuxdriver.com> wrote: > On Tue, Dec 08, 2015 at 10:27:18AM -0800, Tom Herbert wrote: >> Add support for remote checksum offload in both the normal and GRO >> paths. netlink command are used to enable sending of the Remote >> Checksum Data, and allow processing of it on receive. The Remote > Extraneous.
> afsO&^(*&5^a+++NO CARRIER > > Did you mean to finish that sentence? ;-) > >> Signed-off-by: Tom Herbert <t...@herbertland.com> > > Jesse is going to have to comment on your (ab)use of the reserved > fields. I presume that an RFC would be forthcoming? > I'll spin an I-D once there is agreement on the approach. This is identical to VXLAN excepted the bit flag indicating csum_start is present might be different. https://tools.ietf.org/html/draft-herbert-vxlan-rco-00 >> diff --git a/include/net/geneve.h b/include/net/geneve.h >> index 3106ed6..b59ad0a 100644 >> --- a/include/net/geneve.h >> +++ b/include/net/geneve.h >> @@ -8,9 +8,9 @@ >> >> /* Geneve Header: >> * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ >> - * |Ver| Opt Len |O|C| Rsvd. | Protocol Type | >> + * |Ver| Opt Len |O|C|X| Rsvd. | Protocol Type | >> * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ >> - * | Virtual Network Identifier (VNI) | Reserved | >> + * | Virtual Network Identifier (VNI) |U| Csum start | >> * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ >> * | Variable Length Options | >> * +-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+-+ > > Otherwise, LGTM -- I'm really happy to see Geneve get this attention! > > Acked-by: John W. Linville <linvi...@tuxdriver.com> > > -- > John W. Linville Someday the world will need a hero, and you > linvi...@tuxdriver.com might be all we have. Be ready. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
