Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-26 Thread Jakub Kicinski
On Wed, 26 Jun 2019 09:07:29 -0700, Shannon Nelson wrote: > On 6/25/19 4:54 PM, Jakub Kicinski wrote: > > On Thu, 20 Jun 2019 13:24:19 -0700, Shannon Nelson wrote: > >> + running = test_bit(LIF_UP, lif->state); > >> + if (running) > >> + ionic_stop(netdev); > >> + > >> + lif->ntxq_des

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-26 Thread Shannon Nelson
On 6/25/19 4:54 PM, Jakub Kicinski wrote: On Thu, 20 Jun 2019 13:24:19 -0700, Shannon Nelson wrote: + running = test_bit(LIF_UP, lif->state); + if (running) + ionic_stop(netdev); + + lif->ntxq_descs = ring->tx_pending; + lif->nrxq_descs = ring->rx_pending; +

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-25 Thread Jakub Kicinski
On Thu, 20 Jun 2019 13:24:19 -0700, Shannon Nelson wrote: > + running = test_bit(LIF_UP, lif->state); > + if (running) > + ionic_stop(netdev); > + > + lif->ntxq_descs = ring->tx_pending; > + lif->nrxq_descs = ring->rx_pending; > + > + if (running) > + ion

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-24 Thread Shannon Nelson
On 6/24/19 12:26 AM, Michal Kubecek wrote: On Fri, Jun 21, 2019 at 03:30:20PM -0700, Shannon Nelson wrote: On 6/20/19 7:32 PM, Michal Kubecek wrote: On Thu, Jun 20, 2019 at 01:24:19PM -0700, Shannon Nelson wrote: + + if (ch->combined_count > lif->ionic->ntxqs_per_lif) + r

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-24 Thread Michal Kubecek
On Fri, Jun 21, 2019 at 03:30:20PM -0700, Shannon Nelson wrote: > On 6/20/19 7:32 PM, Michal Kubecek wrote: > > On Thu, Jun 20, 2019 at 01:24:19PM -0700, Shannon Nelson wrote: > > > + if (ring->tx_pending > IONIC_MAX_TXRX_DESC || > > > + ring->tx_pending < IONIC_MIN_TXRX_DESC || > > > + rin

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-21 Thread Shannon Nelson
On 6/20/19 7:32 PM, Michal Kubecek wrote: On Thu, Jun 20, 2019 at 01:24:19PM -0700, Shannon Nelson wrote: Add in the basic ethtool callbacks for device information and control. Signed-off-by: Shannon Nelson --- ... +static int ionic_get_link_ksettings(struct net_device *netdev, +

Re: [PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-20 Thread Michal Kubecek
On Thu, Jun 20, 2019 at 01:24:19PM -0700, Shannon Nelson wrote: > Add in the basic ethtool callbacks for device information > and control. > > Signed-off-by: Shannon Nelson > --- ... > +static int ionic_get_link_ksettings(struct net_device *netdev, > + struct ethto

[PATCH net-next 13/18] ionic: Add initial ethtool support

2019-06-20 Thread Shannon Nelson
Add in the basic ethtool callbacks for device information and control. Signed-off-by: Shannon Nelson --- drivers/net/ethernet/pensando/ionic/Makefile | 2 +- .../net/ethernet/pensando/ionic/ionic_dev.h | 3 + .../ethernet/pensando/ionic/ionic_ethtool.c | 533 ++ .../ethe