On Thu, 20 Jun 2019 13:24:19 -0700, Shannon Nelson wrote: > + running = test_bit(LIF_UP, lif->state); > + if (running) > + ionic_stop(netdev); > + > + lif->ntxq_descs = ring->tx_pending; > + lif->nrxq_descs = ring->rx_pending; > + > + if (running) > + ionic_open(netdev); > + clear_bit(LIF_QUEUE_RESET, lif->state);
> + running = test_bit(LIF_UP, lif->state); > + if (running) > + ionic_stop(netdev); > + > + lif->nxqs = ch->combined_count; > + > + if (running) > + ionic_open(netdev); > + clear_bit(LIF_QUEUE_RESET, lif->state); I think we'd rather see the drivers allocate/reserve the resources first, and then perform the configuration once they are as sure as possible it will succeed :( I'm not sure it's a hard requirement, but I think certainly it'd be nice in new drivers.
