Re: [PATCH net-next 12/15] sfc_ef100: add EF100 to NIC-revision enumeration

2020-07-01 Thread David Miller
From: Edward Cree Date: Wed, 1 Jul 2020 23:23:40 +0100 > On 01/07/2020 20:44, David Miller wrote: >> Or is this code used as a library by two "drivers"? > Yes, it is; there will be a second module 'sfc_ef100.ko'which this >  file will be linked into and which will set efx->type to one with >  an

Re: [PATCH net-next 12/15] sfc_ef100: add EF100 to NIC-revision enumeration

2020-07-01 Thread Edward Cree
On 01/07/2020 20:44, David Miller wrote: > Or is this code used as a library by two "drivers"? Yes, it is; there will be a second module 'sfc_ef100.ko'which this  file will be linked into and which will set efx->type to one with  an EF100 revision. Although tbh I have been wondering about another

Re: [PATCH net-next 12/15] sfc_ef100: add EF100 to NIC-revision enumeration

2020-07-01 Thread David Miller
From: Jakub Kicinski Date: Wed, 1 Jul 2020 12:11:31 -0700 > On Wed, 1 Jul 2020 15:55:10 +0100 Edward Cree wrote: >> Also, condition on revision in ethtool drvinfo: if rev is EF100, then >> we must be the sfc_ef100 driver. (We can't rely on KBUILD_MODNAME >> any more, because ethtool_common.o g

Re: [PATCH net-next 12/15] sfc_ef100: add EF100 to NIC-revision enumeration

2020-07-01 Thread Jakub Kicinski
On Wed, 1 Jul 2020 15:55:10 +0100 Edward Cree wrote: > Also, condition on revision in ethtool drvinfo: if rev is EF100, then > we must be the sfc_ef100 driver. (We can't rely on KBUILD_MODNAME > any more, because ethtool_common.o gets linked into both drivers.) > > Signed-off-by: Edward Cree >

[PATCH net-next 12/15] sfc_ef100: add EF100 to NIC-revision enumeration

2020-07-01 Thread Edward Cree
Also, condition on revision in ethtool drvinfo: if rev is EF100, then we must be the sfc_ef100 driver. (We can't rely on KBUILD_MODNAME any more, because ethtool_common.o gets linked into both drivers.) Signed-off-by: Edward Cree --- drivers/net/ethernet/sfc/ethtool_common.c | 5 - driver