From: Edward Cree <ec...@solarflare.com> Date: Wed, 1 Jul 2020 23:23:40 +0100
> On 01/07/2020 20:44, David Miller wrote: >> Or is this code used as a library by two "drivers"? > Yes, it is; there will be a second module 'sfc_ef100.ko'which this > file will be linked into and which will set efx->type to one with > an EF100 revision. > > Although tbh I have been wondering about another approach to > ethtool_get_drvinfo: we could have a const char [] in each driver's > non-common parts, holding KBUILD_MODNAME, which ethtool_common.c > could just reference, rather than looking at efx->type->revision > and relying on the rest of the driver to set it up right. > Since it looks like I'll need to respin this series anyway, I'll try > that and see if it works — it seems cleaner to me. It seems cleaner to me too.
