Re: [PATCH net-next 1/2] net: phy: remove parameter new_link from phy_mac_interrupt()

2018-01-10 Thread Florian Fainelli
On 01/10/2018 12:11 PM, Heiner Kallweit wrote: > I see two issues with parameter new_link: > > 1. It's not needed. See also phy_interrupt(), works w/o this parameter. >phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the >state machine which then calls phy_read_status. And p

[PATCH net-next 1/2] net: phy: remove parameter new_link from phy_mac_interrupt()

2018-01-10 Thread Heiner Kallweit
I see two issues with parameter new_link: 1. It's not needed. See also phy_interrupt(), works w/o this parameter. phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the state machine which then calls phy_read_status. And phy_read_status updates the link state. 2. phy_mac_int