On 01/10/2018 12:11 PM, Heiner Kallweit wrote: > I see two issues with parameter new_link: > > 1. It's not needed. See also phy_interrupt(), works w/o this parameter. > phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the > state machine which then calls phy_read_status. And phy_read_status > updates the link state. > > 2. phy_mac_interrupt is used in interrupt context and getting the link > state may sleep (at least when having to access the PHY registers > via MDIO bus). > > So let's remove it.
This looks fine in premise, but you really need to combine patch 1 and to 2 to avoid a build failure. -- Florian
