On 6/24/19 1:53 PM, Jakub Kicinski wrote:
On Thu, 20 Jun 2019 13:24:08 -0700, Shannon Nelson wrote:
The ionic device has a small set of PCI registers, including a
device control and data space, and a large set of message
commands.
Signed-off-by: Shannon Nelson
struct ionic {
struct p
On 6/24/19 1:13 PM, Jakub Kicinski wrote:
On Fri, 21 Jun 2019 15:22:22 -0700, Shannon Nelson wrote:
+static int identity_show(struct seq_file *seq, void *v)
+{
+ struct ionic *ionic = seq->private;
+ struct identity *ident = &ionic->ident;
+ struct ionic_dev *idev = &ionic->ide
On Thu, 20 Jun 2019 13:24:08 -0700, Shannon Nelson wrote:
> The ionic device has a small set of PCI registers, including a
> device control and data space, and a large set of message
> commands.
>
> Signed-off-by: Shannon Nelson
> struct ionic {
> struct pci_dev *pdev;
> struct devi
On Fri, 21 Jun 2019 15:22:22 -0700, Shannon Nelson wrote:
> >> +static int identity_show(struct seq_file *seq, void *v)
> >> +{
> >> + struct ionic *ionic = seq->private;
> >> + struct identity *ident = &ionic->ident;
> >> + struct ionic_dev *idev = &ionic->idev;
> >> +
> >> + seq_printf(seq, "
On 6/20/19 2:54 PM, Andrew Lunn wrote:
On Thu, Jun 20, 2019 at 01:24:08PM -0700, Shannon Nelson wrote:
+ err = ionic_debugfs_add_dev(ionic);
+ if (err) {
+ dev_err(dev, "Cannot add device debugfs: %d , aborting\n", err);
+ goto err_out_clear_drvdata;
+
Hi Shannon,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046
config: arm-allyesconfig (attached as .config)
compiler:
Hi Shannon,
I love your patch! Yet something to improve:
[auto build test ERROR on net-next/master]
url:
https://github.com/0day-ci/linux/commits/Shannon-Nelson/ionic-Add-basic-framework-for-IONIC-Network-device-driver/20190621-110046
config: i386-allmodconfig (attached as .config)
compiler:
On Thu, Jun 20, 2019 at 01:24:08PM -0700, Shannon Nelson wrote:
> + err = ionic_debugfs_add_dev(ionic);
> + if (err) {
> + dev_err(dev, "Cannot add device debugfs: %d , aborting\n", err);
> + goto err_out_clear_drvdata;
> + }
Hi Shannon
debugfs should not fail,
The ionic device has a small set of PCI registers, including a
device control and data space, and a large set of message
commands.
Signed-off-by: Shannon Nelson
---
drivers/net/ethernet/pensando/ionic/Makefile |2 +-
drivers/net/ethernet/pensando/ionic/ionic.h | 21 +
.../net/ethernet/p
