On Fri, 21 Jun 2019 15:22:22 -0700, Shannon Nelson wrote:
> >> +static int identity_show(struct seq_file *seq, void *v)
> >> +{
> >> + struct ionic *ionic = seq->private;
> >> + struct identity *ident = &ionic->ident;
> >> + struct ionic_dev *idev = &ionic->idev;
> >> +
> >> + seq_printf(seq, "asic_type: 0x%x\n", idev->dev_info.asic_type);
> >> + seq_printf(seq, "asic_rev: 0x%x\n", idev->dev_info.asic_rev);
> >> + seq_printf(seq, "serial_num: %s\n", idev->dev_info.serial_num);
> >> + seq_printf(seq, "fw_version: %s\n", idev->dev_info.fw_version);
> >> + seq_printf(seq, "fw_status: 0x%x\n",
> >> + ioread8(&idev->dev_info_regs->fw_status));
> >> + seq_printf(seq, "fw_heartbeat: 0x%x\n",
> >> + ioread32(&idev->dev_info_regs->fw_heartbeat));
> > devlink just gained a much more flexible version of ethtool -i. Please
> > remove all this and use that.
> Yes, we intend to add a devlink interface, it just isn't in this first
> patchset, which is already plenty big.
Please take this out of your patch set, we can't be expected to merge
debugfs implementation of what has proper APIs :/
