Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-27 Thread David Miller
From: Florian Fainelli Date: Fri, 27 Apr 2018 10:27:38 -0700 > Still not enough coffee, what I am suggesting is actually to make the > body of the functions be static inline functions within > include/net/phy.h that way they get inlined into net/core/ethtool.c and > we can keep PHYLIB modular, do

Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-27 Thread Florian Fainelli
On 04/27/2018 10:19 AM, Florian Fainelli wrote: > > > On 04/27/2018 10:13 AM, David Miller wrote: >> From: David Miller >> Date: Fri, 27 Apr 2018 12:10:14 -0400 (EDT) >> >>> Ugh, this breaks the allmodconfig build. >>> >>> You can't move interfaces to drivers/net/phy/phy.c which are >>> refere

Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-27 Thread Florian Fainelli
On 04/27/2018 10:13 AM, David Miller wrote: > From: David Miller > Date: Fri, 27 Apr 2018 12:10:14 -0400 (EDT) > >> Ugh, this breaks the allmodconfig build. >> >> You can't move interfaces to drivers/net/phy/phy.c which are >> referenced in core networking like net/core/ethtool.c unless you mak

Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-27 Thread Florian Fainelli
On 04/27/2018 09:10 AM, David Miller wrote: > From: David Miller > Date: Fri, 27 Apr 2018 12:00:02 -0400 (EDT) > >> From: Florian Fainelli >> Date: Wed, 25 Apr 2018 12:12:46 -0700 >> >>> This patch series adds support for retrieving PHY statistics with DSA >>> switches >>> when the CPU port u

Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-27 Thread David Miller
From: David Miller Date: Fri, 27 Apr 2018 12:10:14 -0400 (EDT) > Ugh, this breaks the allmodconfig build. > > You can't move interfaces to drivers/net/phy/phy.c which are > referenced in core networking like net/core/ethtool.c unless you make > PHYLIB 'bool' only. > > net/core/ethtool.o: In fun

Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-27 Thread David Miller
From: David Miller Date: Fri, 27 Apr 2018 12:00:02 -0400 (EDT) > From: Florian Fainelli > Date: Wed, 25 Apr 2018 12:12:46 -0700 > >> This patch series adds support for retrieving PHY statistics with DSA >> switches >> when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC). >

Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-27 Thread David Miller
From: Florian Fainelli Date: Wed, 25 Apr 2018 12:12:46 -0700 > This patch series adds support for retrieving PHY statistics with DSA switches > when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC). > To get there a number of things are done: > > - first we move the code deal

Re: [PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-26 Thread Nikita Yushchenko
> Hi all, > > This patch series adds support for retrieving PHY statistics with DSA switches > when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC). > To get there a number of things are done: Tested-By: Nikita Yushchenko Checked on RDU1 and RDU2. FEC PHY statistics keeps s

[PATCH net-next 0/8] net: Extend availability of PHY statistics

2018-04-25 Thread Florian Fainelli
Hi all, This patch series adds support for retrieving PHY statistics with DSA switches when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC). To get there a number of things are done: - first we move the code dealing with PHY statistics outside of net/core/ethtool.c and cre