On 04/27/2018 09:10 AM, David Miller wrote: > From: David Miller <[email protected]> > Date: Fri, 27 Apr 2018 12:00:02 -0400 (EDT) > >> From: Florian Fainelli <[email protected]> >> Date: Wed, 25 Apr 2018 12:12:46 -0700 >> >>> This patch series adds support for retrieving PHY statistics with DSA >>> switches >>> when the CPU port uses a PHY to PHY connection (as opposed to MAC to MAC). >>> To get there a number of things are done: >>> >>> - first we move the code dealing with PHY statistics outside of >>> net/core/ethtool.c >>> and create helper functions since the same code will be reused >>> - then we allow network device drivers to provide an ethtool_get_phy_stats >>> callback >>> when the standard PHY library helpers are not suitable >>> - we update the DSA functions dealing with ethtool operations to get passed >>> a >>> stringset instead of assuming ETH_SS_STATS like they currently do >>> - then we provide a set of standard helpers within DSA as a framework and >>> add >>> the plumbing to allow retrieving the PHY statistics of the CPU port(s) >>> - finally plug support for retrieving such PHY statistics with the b53 >>> driver >> ... >> >> Series applied, thanks Florian. > > Ugh, this breaks the allmodconfig build. > > You can't move interfaces to drivers/net/phy/phy.c which are > referenced in core networking like net/core/ethtool.c unless you make > PHYLIB 'bool' only. > > net/core/ethtool.o: In function `__ethtool_get_sset_count': > ethtool.c:(.text+0x1cd8): undefined reference to `phy_ethtool_get_sset_count' > net/core/ethtool.o: In function `dev_ethtool': > (.text+0x5407): undefined reference to `phy_ethtool_get_strings' > (.text+0x6869): undefined reference to `phy_ethtool_get_sset_count' > (.text+0x69b3): undefined reference to `phy_ethtool_get_stats' > > Please fix this somehow, thanks Florian.
Just seeing this now (this gmail rate limiting again), humm, I can't think of a better way to fix this for now so let's go with your temporary fix. Sorry about that, will come up with a hopefully better alternative that keeps PHY library being fully modular. -- Florian
