On Wed, Sep 30, 2020 at 05:16:56PM +0200, Andrew Lunn wrote:
> > Another question is how to allow ethtool ops setting not only the text
> > message but also the offending attribute.
>
> For PHY tunables, i don't think it is needed. The current API only
> allows a single value to be passed. That se
> Another question is how to allow ethtool ops setting not only the text
> message but also the offending attribute.
For PHY tunables, i don't think it is needed. The current API only
allows a single value to be passed. That seems to be enough, and it
forces us to keep tunables simple. If need be,
On Tue, Sep 29, 2020 at 07:04:13PM +0200, Andrew Lunn wrote:
> On Tue, Sep 29, 2020 at 07:13:04PM +0300, Igor Russkikh wrote:
> > This series implements phy tunables settings via MAC driver callbacks.
> >
> > AQC 10G devices use integrated MAC+PHY solution, where PHY is fully
> > controlled
> > b
On Tue, Sep 29, 2020 at 05:09:48PM -0700, Jakub Kicinski wrote:
> On Tue, 29 Sep 2020 20:47:23 +0200 Andrew Lunn wrote:
> > > Do you mean report supported range via extack?
> >
> > Yes.
> >
> > 811ac400ea33 ("net: phy: dp83869: Add speed optimization feature")
> >
> > was merged recently. It h
On Tue, 29 Sep 2020 20:47:23 +0200 Andrew Lunn wrote:
> > Do you mean report supported range via extack?
>
> Yes.
>
> 811ac400ea33 ("net: phy: dp83869: Add speed optimization feature")
>
> was merged recently. It has:
>
> + default:
> + phydev_err(phydev,
> +
> Do you mean report supported range via extack?
Yes.
811ac400ea33 ("net: phy: dp83869: Add speed optimization feature")
was merged recently. It has:
+ default:
+ phydev_err(phydev,
+ "Downshift count must be 1, 2, 4 or 8\n");
+ return
On Tue, 29 Sep 2020 19:04:13 +0200 Andrew Lunn wrote:
> On Tue, Sep 29, 2020 at 07:13:04PM +0300, Igor Russkikh wrote:
> > This series implements phy tunables settings via MAC driver callbacks.
> >
> > AQC 10G devices use integrated MAC+PHY solution, where PHY is fully
> > controlled
> > by MAC f
On Tue, Sep 29, 2020 at 07:13:04PM +0300, Igor Russkikh wrote:
> This series implements phy tunables settings via MAC driver callbacks.
>
> AQC 10G devices use integrated MAC+PHY solution, where PHY is fully controlled
> by MAC firmware. Therefore, it is not possible to implement separate phy
> d
This series implements phy tunables settings via MAC driver callbacks.
AQC 10G devices use integrated MAC+PHY solution, where PHY is fully controlled
by MAC firmware. Therefore, it is not possible to implement separate phy driver
for these.
We use ethtool ops callbacks to implement downshift and
