On Wed, Sep 30, 2020 at 05:16:56PM +0200, Andrew Lunn wrote: > > Another question is how to allow ethtool ops setting not only the text > > message but also the offending attribute. > > For PHY tunables, i don't think it is needed. The current API only > allows a single value to be passed. That seems to be enough, and it > forces us to keep tunables simple. If need be, the core could set the > attribute, since there should only be one containing the value.
It probably wasn't obvious but I mean the two parts of my e-mail as independent, i.e. the second part was rather meant as a general thought on allowing drivers to report errors/warnings via extack, not specific to PHY tunables. Michal
