Re: [PATCH net-next] tcp: fix slow start after idle vs TSO/GSO

2015-08-21 Thread Eric Dumazet
On Fri, 2015-08-21 at 11:10 -0400, Neal Cardwell wrote: > Very nice catch, and this fix seems like a definite improvement. > > One potential issue is that the connection can restart from idle not > just because new data has been written (which this patch addresses), > but also because the receive

Re: [PATCH net-next] tcp: fix slow start after idle vs TSO/GSO

2015-08-21 Thread Neal Cardwell
On Thu, Aug 20, 2015 at 1:08 PM, Eric Dumazet wrote: > From: Eric Dumazet > > slow start after idle might reduce cwnd, but we perform this > after first packet was cooked and sent. > > With TSO/GSO, it means that we might send a full TSO packet > even if cwnd should have been reduced to IW10. > >

[PATCH net-next] tcp: fix slow start after idle vs TSO/GSO

2015-08-20 Thread Eric Dumazet
From: Eric Dumazet slow start after idle might reduce cwnd, but we perform this after first packet was cooked and sent. With TSO/GSO, it means that we might send a full TSO packet even if cwnd should have been reduced to IW10. Moving the SSAI check in skb_entail() makes sense, because we slight