On Fri, 2015-08-21 at 11:10 -0400, Neal Cardwell wrote:

> Very nice catch, and this fix seems like a definite improvement.
> 
> One potential issue is that the connection can restart from idle not
> just because new data has been written (which this patch addresses),
> but also because the receive window opens and so now packets can be
> sent again. The old version of the code implicitly fired the restart
> code path in the "receive window opens" case as well, since it fired
> every time new data was sent. We might want to check if we need to
> call tcp_cwnd_restart() in tcp_ack_update_window(), next to the call
> for tcp_fast_path_check()?

Excellent, I wrote a 2nd packetdrill test to exercise this path, will
submit a v2 soon.

Thanks Neal


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to