Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread David Miller
From: Craig Gallek Date: Tue, 5 Jan 2016 10:57:13 -0500 > From: Craig Gallek > > Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > Suggested-by: Daniel Borkmann > Signed-off-by: Craig Gallek Also applied, thanks again Craig. -- To unsubscribe from this list: send

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread Eric Dumazet
On Tue, 2016-01-05 at 14:12 -0500, Craig Gallek wrote: > OK, I can buy that an skb should be piped through udp4|6_lib_lookup2, > but I don't think it's safe to remove the skb NULL check in > reuseport_select_sock. There's at least one path (udp_diag.c: > udp_dump_one) which does a lookup without

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread Craig Gallek
On Tue, Jan 5, 2016 at 1:31 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 12:47 -0500, Craig Gallek wrote: >> On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote: > >> > >> > BTW, why UDP calls reuseport_select_sock() with hdr_len == 0 sometimes ? >> hdr_len only matters when you have an skb to

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread Eric Dumazet
On Tue, 2016-01-05 at 12:47 -0500, Craig Gallek wrote: > On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote: > > > > BTW, why UDP calls reuseport_select_sock() with hdr_len == 0 sometimes ? > hdr_len only matters when you have an skb to work with. In both of > the call sites of your suggested p

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread Craig Gallek
On Tue, Jan 5, 2016 at 12:38 PM, Eric Dumazet wrote: > On Tue, 2016-01-05 at 10:57 -0500, Craig Gallek wrote: >> From: Craig Gallek >> >> Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") >> Suggested-by: Daniel Borkmann >> Signed-off-by: Craig Gallek >> --- >> net/co

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread Eric Dumazet
On Tue, 2016-01-05 at 10:57 -0500, Craig Gallek wrote: > From: Craig Gallek > > Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") > Suggested-by: Daniel Borkmann > Signed-off-by: Craig Gallek > --- > net/core/sock_reuseport.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread Daniel Borkmann
On 01/05/2016 04:57 PM, Craig Gallek wrote: From: Craig Gallek Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") Suggested-by: Daniel Borkmann Signed-off-by: Craig Gallek Thanks, Craig. Acked-by: Daniel Borkmann -- To unsubscribe from this list: send the line "un

[PATCH net-next] soreuseport: change consume_skb to kfree_skb in error case

2016-01-05 Thread Craig Gallek
From: Craig Gallek Fixes: 538950a1b752 ("soreuseport: setsockopt SO_ATTACH_REUSEPORT_[CE]BPF") Suggested-by: Daniel Borkmann Signed-off-by: Craig Gallek --- net/core/sock_reuseport.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/core/sock_reuseport.c b/net/core/sock_r