On Tue, 2016-01-05 at 14:12 -0500, Craig Gallek wrote: > OK, I can buy that an skb should be piped through udp4|6_lib_lookup2, > but I don't think it's safe to remove the skb NULL check in > reuseport_select_sock. There's at least one path (udp_diag.c: > udp_dump_one) which does a lookup without an skb. I'll start with > your patch in a separate thread and we can discuss outside the context > of the kfree_skb change.
Well, udp_dump_one() is broken vs SO_REUSEPORT. Fortunately iproute2 does not use it (yet) We need to to get the socket designated by req->id.idiag_cookie, ie ignoring reusport hash or BPF completely. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
