Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 09:25:19 -0700 > It seems that rtnl_group_changelink() can call do_setlink > while a prior call to validate_linkmsg(dev = NULL, ...) could > not validate IFLA_ADDRESS / IFLA_BROADCAST > > Make sure do_setlink() calls validate_linkmsg() instead > of letti

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 09:42:54 -0700 > On 06/05/2018 09:41 AM, David Miller wrote: >> From: Eric Dumazet >> Date: Tue, 5 Jun 2018 09:25:19 -0700 >> >>> It seems that rtnl_group_changelink() can call do_setlink >>> while a prior call to validate_linkmsg(dev = NULL, ...) could

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread Eric Dumazet
On 06/05/2018 09:41 AM, David Miller wrote: > From: Eric Dumazet > Date: Tue, 5 Jun 2018 09:25:19 -0700 > >> It seems that rtnl_group_changelink() can call do_setlink >> while a prior call to validate_linkmsg(dev = NULL, ...) could >> not validate IFLA_ADDRESS / IFLA_BROADCAST >> >> Make sure

Re: [PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread David Miller
From: Eric Dumazet Date: Tue, 5 Jun 2018 09:25:19 -0700 > It seems that rtnl_group_changelink() can call do_setlink > while a prior call to validate_linkmsg(dev = NULL, ...) could > not validate IFLA_ADDRESS / IFLA_BROADCAST > > Make sure do_setlink() calls validate_linkmsg() instead > of letti

[PATCH net-next] rtnetlink: validate attributes in do_setlink()

2018-06-05 Thread Eric Dumazet
It seems that rtnl_group_changelink() can call do_setlink while a prior call to validate_linkmsg(dev = NULL, ...) could not validate IFLA_ADDRESS / IFLA_BROADCAST Make sure do_setlink() calls validate_linkmsg() instead of letting its callers having this responsibility. With help from Dmitry Vyuko