From: Eric Dumazet <eric.duma...@gmail.com> Date: Tue, 5 Jun 2018 09:42:54 -0700
> On 06/05/2018 09:41 AM, David Miller wrote: >> From: Eric Dumazet <eduma...@google.com> >> Date: Tue, 5 Jun 2018 09:25:19 -0700 >> >>> It seems that rtnl_group_changelink() can call do_setlink >>> while a prior call to validate_linkmsg(dev = NULL, ...) could >>> not validate IFLA_ADDRESS / IFLA_BROADCAST >>> >>> Make sure do_setlink() calls validate_linkmsg() instead >>> of letting its callers having this responsibility. >> >> But now rtnl_newlink() will validate_linkmsg() twice.... >> > > Yes, is it a problem ? That is hardly fast path :) Not a problem, just making sure you were aware.
