Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-04-01 Thread Eric Dumazet
On 04/01/2019 10:41 AM, David Miller wrote: > From: Jesper Dangaard Brouer >> >> As Eric says, this in-effect disables GRO for this driver. > > Really? __netif_receive_skb_list_core() does GRO. At least on current public trees, it can not do GRO, since we do not pass a napi context.

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-04-01 Thread David Miller
From: Eric Dumazet Date: Mon, 1 Apr 2019 02:17:12 -0700 > This means no GRO at all I do not think that is true as the SKB list layer does queue up to GRO.

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-04-01 Thread Edward Cree
On 01/04/2019 18:14, David Miller wrote: > From: Eric Dumazet > Date: Mon, 1 Apr 2019 02:17:12 -0700 > >> This means no GRO at all > I do not think that is true as the SKB list layer does queue up to > GRO. No, Eric is right; the current list layer bypasses GRO completely. netif_receive_skb_list(

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-04-01 Thread David Miller
From: Jesper Dangaard Brouer Date: Mon, 1 Apr 2019 14:53:26 +0200 > On Mon, 1 Apr 2019 02:17:12 -0700 > Eric Dumazet wrote: > >> On 03/31/2019 11:11 AM, David Miller wrote: >> > From: Heiner Kallweit >> > Date: Sun, 31 Mar 2019 15:18:48 +0200 >> > >> >> Use netif_receive_skb_list() instead

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-04-01 Thread Heiner Kallweit
On 01.04.2019 19:31, Edward Cree wrote: > On 01/04/2019 18:14, David Miller wrote: >> From: Eric Dumazet >> Date: Mon, 1 Apr 2019 02:17:12 -0700 >> >>> This means no GRO at all >> I do not think that is true as the SKB list layer does queue up to >> GRO. > No, Eric is right; the current list layer

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-04-01 Thread Jesper Dangaard Brouer
On Mon, 1 Apr 2019 02:17:12 -0700 Eric Dumazet wrote: > On 03/31/2019 11:11 AM, David Miller wrote: > > From: Heiner Kallweit > > Date: Sun, 31 Mar 2019 15:18:48 +0200 > > > >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit > >> from batched skb processing. > >> > >> Si

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-04-01 Thread Eric Dumazet
On 03/31/2019 11:11 AM, David Miller wrote: > From: Heiner Kallweit > Date: Sun, 31 Mar 2019 15:18:48 +0200 > >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit >> from batched skb processing. >> >> Signed-off-by: Heiner Kallweit > > Applied. > This means no GRO at al

Re: [PATCH net-next] r8169: use netif_receive_skb_list batching

2019-03-31 Thread David Miller
From: Heiner Kallweit Date: Sun, 31 Mar 2019 15:18:48 +0200 > Use netif_receive_skb_list() instead of napi_gro_receive() to benefit > from batched skb processing. > > Signed-off-by: Heiner Kallweit Applied.

[PATCH net-next] r8169: use netif_receive_skb_list batching

2019-03-31 Thread Heiner Kallweit
Use netif_receive_skb_list() instead of napi_gro_receive() to benefit from batched skb processing. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/e