On Mon, 1 Apr 2019 02:17:12 -0700 Eric Dumazet <eric.duma...@gmail.com> wrote:
> On 03/31/2019 11:11 AM, David Miller wrote: > > From: Heiner Kallweit <hkallwe...@gmail.com> > > Date: Sun, 31 Mar 2019 15:18:48 +0200 > > > >> Use netif_receive_skb_list() instead of napi_gro_receive() to benefit > >> from batched skb processing. > >> > >> Signed-off-by: Heiner Kallweit <hkallwe...@gmail.com> > > > > Applied. > > > > This means no GRO at all, and reduced performance in many useful > cases. As Eric says, this in-effect disables GRO for this driver. This will very likely give a slowdown for local TCP delivery (while it might helps for UDP and forwarding). That is why I was saying we need a GRO version of this... (which need to be combined with bulk SKB alloc, to compete with GRO fast-recycle of same SKB). -- Best regards, Jesper Dangaard Brouer MSc.CS, Principal Kernel Engineer at Red Hat LinkedIn: http://www.linkedin.com/in/brouer
