> > > I noticed a couple of drivers implement both the mii and mdiobus options.
> >
> > Which ones?
>
> boardcom b44.c and bcm63xx_enet.c for example
Thanks. I will take a look at those and maybe ask Florian.
> > Simply getting the link status might be safe, but if
> > set_link_ksettings() or g
On 1/14/21 2:54 PM, Andrew Lunn wrote:
On Tue, Jan 12, 2021 at 11:28:00PM +0100, Marek Vasut wrote:
On 1/11/21 3:47 PM, Andrew Lunn wrote:
On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:
Unless the internal PHY is connected and started, the phylib will not
poll the PHY for state a
On Tue, Jan 12, 2021 at 11:28:00PM +0100, Marek Vasut wrote:
> On 1/11/21 3:47 PM, Andrew Lunn wrote:
> > On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:
> > > Unless the internal PHY is connected and started, the phylib will not
> > > poll the PHY for state and produce state updates.
On 1/11/21 3:43 PM, Heiner Kallweit wrote:
On 11.01.2021 15:10, Marek Vasut wrote:
On 1/11/21 2:50 PM, Heiner Kallweit wrote:
On 11.01.2021 14:38, Marek Vasut wrote:
On 1/11/21 2:26 PM, Heiner Kallweit wrote:
[...]
LGTM. When having a brief look at the driver I stumbled across two things:
1
On 1/11/21 3:47 PM, Andrew Lunn wrote:
On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:
Unless the internal PHY is connected and started, the phylib will not
poll the PHY for state and produce state updates. Connect the PHY and
start/stop it.
Hi Marek
Please continue the conversio
On Mon, Jan 11, 2021 at 01:53:37PM +0100, Marek Vasut wrote:
> Unless the internal PHY is connected and started, the phylib will not
> poll the PHY for state and produce state updates. Connect the PHY and
> start/stop it.
Hi Marek
Please continue the conversion and remove all mii_calls.
ks8851_s
On 11.01.2021 15:10, Marek Vasut wrote:
> On 1/11/21 2:50 PM, Heiner Kallweit wrote:
>> On 11.01.2021 14:38, Marek Vasut wrote:
>>> On 1/11/21 2:26 PM, Heiner Kallweit wrote:
>>> [...]
>>>
LGTM. When having a brief look at the driver I stumbled across two things:
1. Do MAC/PHY suppor
On 1/11/21 2:50 PM, Heiner Kallweit wrote:
On 11.01.2021 14:38, Marek Vasut wrote:
On 1/11/21 2:26 PM, Heiner Kallweit wrote:
[...]
LGTM. When having a brief look at the driver I stumbled across two things:
1. Do MAC/PHY support any pause mode? Then a call to
phy_support_(a)sym_pause() w
On 11.01.2021 14:38, Marek Vasut wrote:
> On 1/11/21 2:26 PM, Heiner Kallweit wrote:
> [...]
>
>> LGTM. When having a brief look at the driver I stumbled across two things:
>>
>> 1. Do MAC/PHY support any pause mode? Then a call to
>> phy_support_(a)sym_pause() would be missing.
>
> https://w
On 1/11/21 2:26 PM, Heiner Kallweit wrote:
[...]
LGTM. When having a brief look at the driver I stumbled across two things:
1. Do MAC/PHY support any pause mode? Then a call to
phy_support_(a)sym_pause() would be missing.
https://ww1.microchip.com/downloads/en/DeviceDoc/KSZ8851-16MLL-Sing
On 11.01.2021 13:53, Marek Vasut wrote:
> Unless the internal PHY is connected and started, the phylib will not
> poll the PHY for state and produce state updates. Connect the PHY and
> start/stop it.
>
> Signed-off-by: Marek Vasut
> Cc: Andrew Lunn
> Cc: Heiner Kallweit
> Cc: Lukas Wunner
> -
Unless the internal PHY is connected and started, the phylib will not
poll the PHY for state and produce state updates. Connect the PHY and
start/stop it.
Signed-off-by: Marek Vasut
Cc: Andrew Lunn
Cc: Heiner Kallweit
Cc: Lukas Wunner
---
drivers/net/ethernet/micrel/ks8851.h| 2 ++
d
12 matches
Mail list logo
