> > > I noticed a couple of drivers implement both the mii and mdiobus options.
> >
> > Which ones?
>
> boardcom b44.c and bcm63xx_enet.c for example
Thanks. I will take a look at those and maybe ask Florian.
> > Simply getting the link status might be safe, but if
> > set_link_ksettings() or get_link_ksettings() is used, phylib is going
> > to get confused when the PHY is changed without it knowing.. So please
> > do remove all the mii calls as part of the patchset.
>
> Isn't that gonna break some ABI ?
I guess not, but i have no definitive answer. It should add more
features, not take any away.
> Also, is separate patch OK ?
It obviously works well enough that you have not run into issues. So i
guess anybody doing a git bisect will be O.K. if they land on the
state with both phydev and mii. So yes, a separate patch is O.K.
Andrew
