Re: [PATCH net-next] net: dsa: sja1105: Add support for port mirroring

2019-10-03 Thread Vladimir Oltean
Hi David, On Thu, 3 Oct 2019 at 22:04, David Miller wrote: > > From: Vladimir Oltean > Date: Thu, 3 Oct 2019 02:34:43 +0300 > > > + already_enabled = (general_params->mirr_port != SJA1105_NUM_PORTS); > > + if (already_enabled && enabled && general_params->mirr_port != to) { > > +

Re: [PATCH net-next] net: dsa: sja1105: Add support for port mirroring

2019-10-03 Thread David Miller
From: Vladimir Oltean Date: Thu, 3 Oct 2019 02:34:43 +0300 > + already_enabled = (general_params->mirr_port != SJA1105_NUM_PORTS); > + if (already_enabled && enabled && general_params->mirr_port != to) { > + dev_err(priv->ds->dev, > + "Delete mirroring rul

[PATCH net-next] net: dsa: sja1105: Add support for port mirroring

2019-10-02 Thread Vladimir Oltean
Amazingly, of all features, this does not require a switch reset. Tested with: tc qdisc add dev swp2 clsact tc filter add dev swp2 ingress matchall skip_sw \ action mirred egress mirror dev swp3 tc filter show dev swp2 ingress tc filter del dev swp2 ingress pref 49152 Signed-off-by: Vlad