Hi David,
On Thu, 3 Oct 2019 at 22:04, David Miller <da...@davemloft.net> wrote:
>
> From: Vladimir Oltean <olte...@gmail.com>
> Date: Thu, 3 Oct 2019 02:34:43 +0300
>
> > + already_enabled = (general_params->mirr_port != SJA1105_NUM_PORTS);
> > + if (already_enabled && enabled && general_params->mirr_port != to) {
> > + dev_err(priv->ds->dev,
> > + "Delete mirroring rules towards port %d first", to);
> > + return -EBUSY;
> > + }
>
> In this situation, the user is trying to add a mirror rule to port 'to'
> when we already have rules pointing to "general_params->mirr_port".
>
> So you should be printing out the value of "general_params->mirr_port"
> in this message rather than 'to'.
Good catch, thanks.
-Vladimir
