Re: [PATCH net-next] net: diag: add workaround for inode truncation

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 09:36:13 -0700 Jakub Kicinski wrote: > On Tue, 1 Sep 2020 08:55:29 +0200 Eric Dumazet wrote: > > On 8/31/20 4:59 PM, Jakub Kicinski wrote: > > > Dave reports that struct inet_diag_msg::idiag_inode is 32 bit, > > > while inode's type is unsigned long. This leads to truncation. >

Re: [PATCH net-next] net: diag: add workaround for inode truncation

2020-09-01 Thread Jakub Kicinski
On Tue, 1 Sep 2020 08:55:29 +0200 Eric Dumazet wrote: > On 8/31/20 4:59 PM, Jakub Kicinski wrote: > > Dave reports that struct inet_diag_msg::idiag_inode is 32 bit, > > while inode's type is unsigned long. This leads to truncation. > > > > Since there is nothing we can do about the size of existin

Re: [PATCH net-next] net: diag: add workaround for inode truncation

2020-08-31 Thread Eric Dumazet
On 8/31/20 4:59 PM, Jakub Kicinski wrote: > Dave reports that struct inet_diag_msg::idiag_inode is 32 bit, > while inode's type is unsigned long. This leads to truncation. > > Since there is nothing we can do about the size of existing > fields - add a new attribute to carry 64 bit inode number

[PATCH net-next] net: diag: add workaround for inode truncation

2020-08-31 Thread Jakub Kicinski
Dave reports that struct inet_diag_msg::idiag_inode is 32 bit, while inode's type is unsigned long. This leads to truncation. Since there is nothing we can do about the size of existing fields - add a new attribute to carry 64 bit inode numbers. Reported-by: Dave Marchevsky Signed-off-by: Jakub