On Tue, 1 Sep 2020 09:36:13 -0700 Jakub Kicinski wrote: > On Tue, 1 Sep 2020 08:55:29 +0200 Eric Dumazet wrote: > > On 8/31/20 4:59 PM, Jakub Kicinski wrote: > > > Dave reports that struct inet_diag_msg::idiag_inode is 32 bit, > > > while inode's type is unsigned long. This leads to truncation. > > > > > > Since there is nothing we can do about the size of existing > > > fields - add a new attribute to carry 64 bit inode numbers. > > > > Last time I checked socket inode numbers were 32bit ? > > > > Is there a plan changing this ? > > Ugh, you're right that appears to be a local patch :/ > > I should have checked, sorry for the noise.
Looking at get_next_ino() - it seems like the risk of overflow is very real, no? Should we not address this?
