Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-05 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 02:01:24PM -0700, Alexander Duyck wrote: > On 06/03/2015 01:02 PM, Andy Gospodarek wrote: [...] > > > >>>@@ -621,7 +623,7 @@ static int fib_check_nh(struct fib_config *cfg, struct > >>>fib_info *fi, > >>> /* It is not necessary, but requires a bit of think

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Alexander Duyck
On 06/03/2015 01:02 PM, Andy Gospodarek wrote: On Wed, Jun 03, 2015 at 11:25:09AM -0700, Alexander Duyck wrote: On 06/02/2015 08:07 PM, Andy Gospodarek wrote: [...] Though there were some that preferred not to have a configuration option and to make this behavior the default when it was discus

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Wed, Jun 3, 2015, at 22:34, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 10:04:06PM +0200, Hannes Frederic Sowa wrote: > > On Wed, Jun 3, 2015, at 20:27, Andy Gospodarek wrote: > > > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > > > > On Tue, Jun 2, 2015 at 8:07 PM, Andy G

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 10:04:06PM +0200, Hannes Frederic Sowa wrote: > On Wed, Jun 3, 2015, at 20:27, Andy Gospodarek wrote: > > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > > > On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > > > wrote: > > > > This feature is only enabled w

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 12:03:53PM -0700, Scott Feldman wrote: > On Wed, Jun 3, 2015 at 11:27 AM, Andy Gospodarek > wrote: > > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > >> wrote: > >> > This feature is only enabled with t

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Wed, Jun 3, 2015, at 20:27, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > > On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > > wrote: > > > This feature is only enabled with the new sysctl set (default is off): > > > net.core.kill_routes_on_linkdown

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:25:09AM -0700, Alexander Duyck wrote: > On 06/02/2015 08:07 PM, Andy Gospodarek wrote: [...] > >Though there were some that preferred not to have a configuration option > >and to make this behavior the default when it was discussed in Ottawa > >earlier this year since "i

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Wed, Jun 3, 2015 at 11:27 AM, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek >> wrote: >> > This feature is only enabled with the new sysctl set (default is off): >> > net.core.kill_routes_on_linkdown =

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:15:55AM -0700, Scott Feldman wrote: > On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > wrote: > > This feature is only enabled with the new sysctl set (default is off): > > net.core.kill_routes_on_linkdown = 1 > > One more thing, sorry. This feature is typically imple

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Alexander Duyck
On 06/02/2015 08:07 PM, Andy Gospodarek wrote: This patch adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving a

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:12:11AM -0700, Scott Feldman wrote: > On Wed, Jun 3, 2015 at 10:57 AM, Andy Gospodarek > wrote: > > On Wed, Jun 03, 2015 at 10:40:26AM -0700, Scott Feldman wrote: > >> On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek > >> wrote: > >> > On Tue, Jun 02, 2015 at 10:03:23PM

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek wrote: > This feature is only enabled with the new sysctl set (default is off): > net.core.kill_routes_on_linkdown = 1 One more thing, sorry. This feature is typically implemented today in user-space on a per-interface basis. The example I'm think

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Wed, Jun 3, 2015 at 10:57 AM, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 10:40:26AM -0700, Scott Feldman wrote: >> On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek >> wrote: >> > On Tue, Jun 02, 2015 at 10:03:23PM -0700, Scott Feldman wrote: >> >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gosp

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 10:40:26AM -0700, Scott Feldman wrote: > On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek > wrote: > > On Tue, Jun 02, 2015 at 10:03:23PM -0700, Scott Feldman wrote: > >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > >> wrote: > >> > This patch adds the ability to have

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Wed, Jun 03, 2015 at 11:16:27AM -0400, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 11:02:23AM -0400, Neil Horman wrote: > > On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: > > > On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > > > > On Wed, Jun 03, 2015 at 04:

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Scott Feldman
On Wed, Jun 3, 2015 at 8:12 AM, Andy Gospodarek wrote: > On Tue, Jun 02, 2015 at 10:03:23PM -0700, Scott Feldman wrote: >> On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek >> wrote: >> > This patch adds the ability to have the Linux kernel track whether or >> > not a particular route should be use

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Mi, 2015-06-03 at 11:02 -0400, Neil Horman wrote: > On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: > > On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > > > On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > > > > On Mi, 2015-06-03 at 09:53 -04

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:02:23AM -0400, Neil Horman wrote: > On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: > > On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > > > On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > > > > On Mi, 2015-06-03 at 0

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Tue, Jun 02, 2015 at 10:03:23PM -0700, Scott Feldman wrote: > On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek > wrote: > > This patch adds the ability to have the Linux kernel track whether or > > not a particular route should be used based on the link-status of the > > interface associated wit

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Wed, Jun 03, 2015 at 10:46:22AM -0400, Andy Gospodarek wrote: > On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > > On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > > > On Mi, 2015-06-03 at 09:53 -0400, Neil Horman wrote: > > > > On Tue, Jun 02, 2015 at 11:07:

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 10:21:31AM -0400, Neil Horman wrote: > On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > > On Mi, 2015-06-03 at 09:53 -0400, Neil Horman wrote: > > > On Tue, Jun 02, 2015 at 11:07:19PM -0400, Andy Gospodarek wrote: > > > > This patch adds the ability to

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Mi, 2015-06-03 at 10:21 -0400, Neil Horman wrote: > On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > > On Mi, 2015-06-03 at 09:53 -0400, Neil Horman wrote: > > > On Tue, Jun 02, 2015 at 11:07:19PM -0400, Andy Gospodarek wrote: > > > > This patch adds the ability to have th

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 04:03:48PM +0200, Hannes Frederic Sowa wrote: > On Di, 2015-06-02 at 23:07 -0400, Andy Gospodarek wrote: > > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > > index 6f5f71f..5bd953c 100644 > > --- a/include/linux/netdevice.h > > +++ b/include/linux/netde

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Wed, Jun 03, 2015 at 04:13:08PM +0200, Hannes Frederic Sowa wrote: > On Mi, 2015-06-03 at 09:53 -0400, Neil Horman wrote: > > On Tue, Jun 02, 2015 at 11:07:19PM -0400, Andy Gospodarek wrote: > > > This patch adds the ability to have the Linux kernel track whether or > > > not a particular route

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Mi, 2015-06-03 at 09:53 -0400, Neil Horman wrote: > On Tue, Jun 02, 2015 at 11:07:19PM -0400, Andy Gospodarek wrote: > > This patch adds the ability to have the Linux kernel track whether or > > not a particular route should be used based on the link-status of the > > interface associated with t

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Di, 2015-06-02 at 23:07 -0400, Andy Gospodarek wrote: > diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h > index 6f5f71f..5bd953c 100644 > --- a/include/linux/netdevice.h > +++ b/include/linux/netdevice.h > @@ -2986,6 +2986,7 @@ int dev_forward_skb(struct net_device *dev, struc

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Neil Horman
On Tue, Jun 02, 2015 at 11:07:19PM -0400, Andy Gospodarek wrote: > This patch adds the ability to have the Linux kernel track whether or > not a particular route should be used based on the link-status of the > interface associated with the next-hop. > > Before this patch any link-failure on an in

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Andy Gospodarek
On Wed, Jun 03, 2015 at 11:35:09AM +0200, Hannes Frederic Sowa wrote: > On Wed, Jun 3, 2015, at 05:07, Andy Gospodarek wrote: > > This patch adds the ability to have the Linux kernel track whether or > > not a particular route should be used based on the link-status of the > > interface associated

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-03 Thread Hannes Frederic Sowa
On Wed, Jun 3, 2015, at 05:07, Andy Gospodarek wrote: > This patch adds the ability to have the Linux kernel track whether or > not a particular route should be used based on the link-status of the > interface associated with the next-hop. > > Before this patch any link-failure on an interface tha

Re: [PATCH net-next] net: change fib behavior based on interface link status

2015-06-02 Thread Scott Feldman
On Tue, Jun 2, 2015 at 8:07 PM, Andy Gospodarek wrote: > This patch adds the ability to have the Linux kernel track whether or > not a particular route should be used based on the link-status of the > interface associated with the next-hop. > > Before this patch any link-failure on an interface th

[PATCH net-next] net: change fib behavior based on interface link status

2015-06-02 Thread Andy Gospodarek
This patch adds the ability to have the Linux kernel track whether or not a particular route should be used based on the link-status of the interface associated with the next-hop. Before this patch any link-failure on an interface that was serving as a gateway for some systems could result in thos