Re: [PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file

2021-04-08 Thread Andrew Lunn
On Thu, Apr 08, 2021 at 01:58:13PM +0300, Danielle Ratson wrote: > __ethtool_get_link_ksettings() function is shared by both ioctl and > netlink ethtool interfaces. > > Move it to net/ethtool/common.c file, which is the suitable place for > a shared code. > > Signed-off-by: Danielle Ratson > Sug

[PATCH net-next] ethtool: Move __ethtool_get_link_ksettings() to common file

2021-04-08 Thread Danielle Ratson
__ethtool_get_link_ksettings() function is shared by both ioctl and netlink ethtool interfaces. Move it to net/ethtool/common.c file, which is the suitable place for a shared code. Signed-off-by: Danielle Ratson Suggested-by: Jakub Kicinski Reviewed-by: Ido Schimmel Reviewed-by: Jiri Pirko --