On Thu, Apr 08, 2021 at 01:58:13PM +0300, Danielle Ratson wrote:
> __ethtool_get_link_ksettings() function is shared by both ioctl and
> netlink ethtool interfaces.
> 
> Move it to net/ethtool/common.c file, which is the suitable place for
> a shared code.
> 
> Signed-off-by: Danielle Ratson <daniel...@nvidia.com>
> Suggested-by: Jakub Kicinski <k...@kernel.org>
> Reviewed-by: Ido Schimmel <ido...@nvidia.com>
> Reviewed-by: Jiri Pirko <j...@nvidia.com>

Seems sensible.

Did you look to see what else is shared and should move? Rather than
doing it one function at a time, can we do it all at once?

    Andrew

Reply via email to