Re: [PATCH net-next] bpf: restore skb->sk before pskb_trim() call

2017-04-30 Thread David Miller
From: Eric Dumazet Date: Wed, 26 Apr 2017 09:09:23 -0700 > From: Eric Dumazet > > While testing a fix [1] in ___pskb_trim(), addressing the WARN_ON_ONCE() > in skb_try_coalesce() reported by Andrey, I found that we had an skb > with skb->sk set but no skb->destructor. > > This invalidated heur

Re: [PATCH net-next] bpf: restore skb->sk before pskb_trim() call

2017-04-26 Thread Willem de Bruijn
On Wed, Apr 26, 2017 at 4:53 PM, Alexei Starovoitov wrote: > On Wed, Apr 26, 2017 at 09:09:23AM -0700, Eric Dumazet wrote: >> From: Eric Dumazet >> >> While testing a fix [1] in ___pskb_trim(), addressing the WARN_ON_ONCE() >> in skb_try_coalesce() reported by Andrey, I found that we had an skb >

Re: [PATCH net-next] bpf: restore skb->sk before pskb_trim() call

2017-04-26 Thread Alexei Starovoitov
On Wed, Apr 26, 2017 at 09:09:23AM -0700, Eric Dumazet wrote: > From: Eric Dumazet > > While testing a fix [1] in ___pskb_trim(), addressing the WARN_ON_ONCE() > in skb_try_coalesce() reported by Andrey, I found that we had an skb > with skb->sk set but no skb->destructor. > > This invalidated h

Re: [PATCH net-next] bpf: restore skb->sk before pskb_trim() call

2017-04-26 Thread Daniel Borkmann
On 04/26/2017 06:09 PM, Eric Dumazet wrote: From: Eric Dumazet While testing a fix [1] in ___pskb_trim(), addressing the WARN_ON_ONCE() in skb_try_coalesce() reported by Andrey, I found that we had an skb with skb->sk set but no skb->destructor. This invalidated heuristic found in commit 158f3

[PATCH net-next] bpf: restore skb->sk before pskb_trim() call

2017-04-26 Thread Eric Dumazet
From: Eric Dumazet While testing a fix [1] in ___pskb_trim(), addressing the WARN_ON_ONCE() in skb_try_coalesce() reported by Andrey, I found that we had an skb with skb->sk set but no skb->destructor. This invalidated heuristic found in commit 158f323b9868 ("net: adjust skb->truesize in pskb_ex