On Wed, Apr 26, 2017 at 4:53 PM, Alexei Starovoitov <[email protected]> wrote: > On Wed, Apr 26, 2017 at 09:09:23AM -0700, Eric Dumazet wrote: >> From: Eric Dumazet <[email protected]> >> >> While testing a fix [1] in ___pskb_trim(), addressing the WARN_ON_ONCE() >> in skb_try_coalesce() reported by Andrey, I found that we had an skb >> with skb->sk set but no skb->destructor. >> >> This invalidated heuristic found in commit 158f323b9868 ("net: adjust >> skb->truesize in pskb_expand_head()") and in cited patch. >> >> Considering the BUG_ON(skb->sk) we have in skb_orphan(), we should >> restrain the temporary setting to a minimal section. >> >> [1] https://patchwork.ozlabs.org/patch/755570/ >> net: adjust skb->truesize in ___pskb_trim() >> >> Fixes: 8f917bba0042 ("bpf: pass sk to helper functions") >> Signed-off-by: Eric Dumazet <[email protected]> >> Cc: Willem de Bruijn <[email protected]> >> Cc: Andrey Konovalov <[email protected]> > > Ahh. Thanks for the fix. > Acked-by: Alexei Starovoitov <[email protected]>
Acked-by: Willem de Bruijn <[email protected]> Thanks, Eric.
