Re: [PATCH net-next,v2 04/12] cls_api: add translator to flow_action representation

2018-11-19 Thread Jiri Pirko
Mon, Nov 19, 2018 at 02:21:41PM CET, pa...@netfilter.org wrote: >On Mon, Nov 19, 2018 at 01:12:51PM +0100, Jiri Pirko wrote: >> Mon, Nov 19, 2018 at 01:15:11AM CET, pa...@netfilter.org wrote: >> >@@ -2567,6 +2575,111 @@ int tc_setup_cb_call(struct tcf_block *block, >> >struct tcf_exts *exts, >> >

Re: [PATCH net-next,v2 04/12] cls_api: add translator to flow_action representation

2018-11-19 Thread Pablo Neira Ayuso
On Mon, Nov 19, 2018 at 01:12:51PM +0100, Jiri Pirko wrote: > Mon, Nov 19, 2018 at 01:15:11AM CET, pa...@netfilter.org wrote: > >@@ -2567,6 +2575,111 @@ int tc_setup_cb_call(struct tcf_block *block, struct > >tcf_exts *exts, > > } > > EXPORT_SYMBOL(tc_setup_cb_call); > > > >+int tc_setup_flow_act

Re: [PATCH net-next,v2 04/12] cls_api: add translator to flow_action representation

2018-11-19 Thread Pablo Neira Ayuso
On Mon, Nov 19, 2018 at 01:16:30PM +0100, Jiri Pirko wrote: > >@@ -391,18 +392,27 @@ static int fl_hw_replace_filter(struct tcf_proto *tp, > > cls_flower.exts = &f->exts; > > cls_flower.classid = f->res.classid; > > > >+if (tc_setup_flow_action(&f->action, &f->exts) < 0) > >+

Re: [PATCH net-next,v2 04/12] cls_api: add translator to flow_action representation

2018-11-19 Thread Jiri Pirko
Mon, Nov 19, 2018 at 01:15:11AM CET, pa...@netfilter.org wrote: >This patch implements a new function to translate from native TC action >to the new flow_action representation. Moreover, this patch also updates >cls_flower to use this new function. > >Signed-off-by: Pablo Neira Ayuso >--- >v2: no

Re: [PATCH net-next,v2 04/12] cls_api: add translator to flow_action representation

2018-11-19 Thread Jiri Pirko
Mon, Nov 19, 2018 at 01:15:11AM CET, pa...@netfilter.org wrote: >This patch implements a new function to translate from native TC action >to the new flow_action representation. Moreover, this patch also updates >cls_flower to use this new function. > >Signed-off-by: Pablo Neira Ayuso >--- >v2: no

[PATCH net-next,v2 04/12] cls_api: add translator to flow_action representation

2018-11-18 Thread Pablo Neira Ayuso
This patch implements a new function to translate from native TC action to the new flow_action representation. Moreover, this patch also updates cls_flower to use this new function. Signed-off-by: Pablo Neira Ayuso --- v2: no changes. include/net/pkt_cls.h | 3 ++ net/sched/cls_api.c| 11