On Mon, Nov 19, 2018 at 01:16:30PM +0100, Jiri Pirko wrote:
> >@@ -391,18 +392,27 @@ static int fl_hw_replace_filter(struct tcf_proto *tp,
> >     cls_flower.exts = &f->exts;
> >     cls_flower.classid = f->res.classid;
> > 
> >+    if (tc_setup_flow_action(&f->action, &f->exts) < 0)
> >+            return -ENOMEM;
> >+
> >+    cls_flower.rule.action.keys = f->action.keys;
> >+    cls_flower.rule.action.num_keys = f->action.num_keys;
> 
> Hmm, I think flow actions should be only field in rule. Flower does not
> use it internally, so it does not really make sense to have f->action

OK, will remove this new field from flower.

Thanks!

Reply via email to